]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
st/scroll-view: Allow removing edge fade
authorJulian Sparber <julian@sparber.net>
Thu, 7 Dec 2023 16:37:35 +0000 (17:37 +0100)
committerJulian Sparber <julian@sparber.net>
Thu, 7 Dec 2023 17:15:51 +0000 (18:15 +0100)
Remove the fade effect when the css property `-st-vfade-offset` is removed
from a widget. The effect isn't added when the property never existed.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3047>

src/st/st-scroll-view.c

index 8c7636126e10696e9780f5e53016bbf5c7c1a86a..1da7ce91fb61464165c6e1314c6dcf59756508fe 100644 (file)
@@ -720,24 +720,20 @@ static void
 st_scroll_view_style_changed (StWidget *widget)
 {
   StScrollView *self = ST_SCROLL_VIEW (widget);
-  gboolean has_vfade, has_hfade;
   double vfade_offset = 0.0;
   double hfade_offset = 0.0;
 
   StThemeNode *theme_node = st_widget_get_theme_node (widget);
 
-  has_vfade = st_theme_node_lookup_length (theme_node, "-st-vfade-offset", FALSE, &vfade_offset);
-  has_hfade = st_theme_node_lookup_length (theme_node, "-st-hfade-offset", FALSE, &hfade_offset);
-  if (has_vfade || has_hfade)
-    {
-      st_scroll_view_update_fade_effect (self,
-                                         &(ClutterMargin) {
-                                           .top = vfade_offset,
-                                           .bottom = vfade_offset,
-                                           .left = hfade_offset,
-                                           .right = hfade_offset,
-                                         });
-    }
+  st_theme_node_lookup_length (theme_node, "-st-vfade-offset", FALSE, &vfade_offset);
+  st_theme_node_lookup_length (theme_node, "-st-hfade-offset", FALSE, &hfade_offset);
+  st_scroll_view_update_fade_effect (self,
+                                     &(ClutterMargin) {
+                                       .top = vfade_offset,
+                                       .bottom = vfade_offset,
+                                       .left = hfade_offset,
+                                       .right = hfade_offset,
+                                     });
 
   ST_WIDGET_CLASS (st_scroll_view_parent_class)->style_changed (widget);
 }